Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py@178 PS1, Line 178: expect_results_t(cast_ts(ts_4) + " - interval 5 seconds", []) > I might have misunderstood something, but isn't the synchronization problem We use execute_query_ts which works the following way: * executes query * returns current timestamp The Iceberg snapshot is being created during the INSERT statement at L171. After the snapshot is created it takes some time for Impala to reload the table and return the query results. If the machine is too busy then it might take more than one sec. Hopefully it won't take more than 5 seconds. We need to sleep 5 seconds before the INSERT to make sure that traveling backwards 5 seconds from 'ts_4' will hit a timepoint after ts_3 but before ts_4 (when the table was empty). -- To view, visit http://gerrit.cloudera.org:8080/17928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8 Gerrit-Change-Number: 17928 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 13:20:47 +0000 Gerrit-HasComments: Yes
