Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17928 )
Change subject: IMPALA-10955: test_time_travel is flaky ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/17928/1/tests/query_test/test_iceberg.py@178 PS1, Line 178: expect_results_t(quote(ts_4), ['100']) > Got it, thank you for the explanation. `now() - ts_3 + 1s` wouldn't work, but I added `ts_3 + 1s`. If `ts_4 - 5s` remains flaky then probably we'll only keep ts_3+1s. Or we could retrieve the Iceberg timestamps from the table which would be the most robust solution. -- To view, visit http://gerrit.cloudera.org:8080/17928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia270781dfdc4101b0d961db5aa20fc1678cdaaa8 Gerrit-Change-Number: 17928 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 13:57:53 +0000 Gerrit-HasComments: Yes
