Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17919 )
Change subject: IMPALA-10975: Minor refactoring in alter table ddl op in CatalogOpExecutor ...................................................................... Patch Set 6: (2 comments) I can bump it up to +2 after the minor suggestions below are resolved. Since the suggested changes are only in commit msg, I don't believe we need to have a full precommit run again. http://gerrit.cloudera.org:8080/#/c/17919/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17919/6//COMMIT_MSG@7 PS6, Line 7: Minor refactoring in alter table ddl op in : CatalogOpExecutor please keep this to one line as per convention. Suggest you to just title is "Refactor alter table ddl operation" or something similar. http://gerrit.cloudera.org:8080/#/c/17919/6//COMMIT_MSG@19 PS6, Line 19: s Can you also mention about the additional bug fix in the addToDeleteEventLog method? -- To view, visit http://gerrit.cloudera.org:8080/17919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbadcab68b4599ad18b681b1284052a47b74d802 Gerrit-Change-Number: 17919 Gerrit-PatchSet: 6 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Wed, 20 Oct 2021 22:55:31 +0000 Gerrit-HasComments: Yes
