Sourabh Goyal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17919 )

Change subject: IMPALA-10975: Refactor alter table ddl operation
......................................................................


Patch Set 7:

(2 comments)

@Vihang: Thanks for the feedback. I have addressed the review comments.

http://gerrit.cloudera.org:8080/#/c/17919/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17919/6//COMMIT_MSG@7
PS6, Line 7: Refactor alter table ddl operation
           :
> please keep this to one line as per convention. Suggest you to just title i
Sure


http://gerrit.cloudera.org:8080/#/c/17919/6//COMMIT_MSG@19
PS6, Line 19:
> Can you also mention about the additional bug fix in the addToDeleteEventLo
Sure.



--
To view, visit http://gerrit.cloudera.org:8080/17919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbadcab68b4599ad18b681b1284052a47b74d802
Gerrit-Change-Number: 17919
Gerrit-PatchSet: 7
Gerrit-Owner: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Yu-Wen Lai <[email protected]>
Gerrit-Comment-Date: Thu, 21 Oct 2021 09:19:19 +0000
Gerrit-HasComments: Yes

Reply via email to