Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 )
Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever ...................................................................... Patch Set 34: (2 comments) Ok, this is looking good to me. I'm ready to approve this. I had only one nit. http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17872/33/be/src/service/client-request-state.cc@703 PS33, Line 703: if (exec_in_worker_t > Renamed to exec_in_worker_thread. I was having hard time interpreting the p Thanks, this makes sense. http://gerrit.cloudera.org:8080/#/c/17872/34/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/17872/34/tests/metadata/test_ddl.py@1066 PS34, Line 1066: assert(exec_time >= 4) Nit: This can be "assert(exec_time >= 10)" -- To view, visit http://gerrit.cloudera.org:8080/17872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e Gerrit-Change-Number: 17872 Gerrit-PatchSet: 34 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Thu, 21 Oct 2021 18:10:24 +0000 Gerrit-HasComments: Yes
