Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 )
Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever ...................................................................... Patch Set 32: (3 comments) Thanks a lot Joe! Your timing tests are great and included. http://gerrit.cloudera.org:8080/#/c/17872/31/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17872/31/be/src/service/client-request-state.cc@695 PS31, Line 695: (bool > Nit: What do you think about dropping Async from this name? Done http://gerrit.cloudera.org:8080/#/c/17872/31/be/src/service/client-request-state.cc@702 PS31, Line 702: // Indirectly check if running in thread async_exec_thread_. : if (exec_dml_sync) { > When I was reading this code, I got confused by the variable name. The code Done http://gerrit.cloudera.org:8080/#/c/17872/31/be/src/service/client-request-state.cc@706 PS31, Line 706: // 1. For any non-CTAS DDLs, transition to RUNNING : // 2. For CTAS DDLs, transition to RUNNING during FinishExecQueryOrDml > When adding a delay, it usually lines up with some piece of code that can t Done -- To view, visit http://gerrit.cloudera.org:8080/17872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e Gerrit-Change-Number: 17872 Gerrit-PatchSet: 32 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Thu, 21 Oct 2021 15:40:09 +0000 Gerrit-HasComments: Yes
