Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17960 )
Change subject: IMPALA-10777: Enable min/max filtering for Iceberg partitions ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17960/1/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17960/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@1323 PS1, Line 1323: if (scan_node_->hdfs_table()->IsIcebergTable()) return false; > Yeah, good question how could we make it a bit more elegant. Should I add a Ideally, is_computed_column can be a new boolean field to TColumn, together with an expression on how the computation is done, such EXTRACT(DAY FROM timestamp_col). For this patch, looks like we may not need that at all if we can set is_bound_by_partition_columns properly in FE even for the computed column. 120 bool IsBoundByPartitionColumn(int plan_id) const { 121 int target_ndx = filter_desc().planid_to_target_ndx.at(plan_id); 122 return filter_desc().targets[target_ndx].is_bound_by_partition_columns; 123 } http://gerrit.cloudera.org:8080/#/c/17960/2/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17960/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@678 PS2, Line 678: && IsSimplePartitionedTable() Since a computed partition column is a partition column, I wonder if there is a need to make a test here? -- To view, visit http://gerrit.cloudera.org:8080/17960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51b53188c6da7eeebfeae385e1de31ace0980cac Gerrit-Change-Number: 17960 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 22 Oct 2021 13:41:36 +0000 Gerrit-HasComments: Yes
