Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17960 )
Change subject: IMPALA-10777: Enable min/max filtering for Iceberg partitions ...................................................................... Patch Set 3: (2 comments) Hi Zoltan, Added a readability nit and a test comment, apart from these LGTM. http://gerrit.cloudera.org:8080/#/c/17960/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/17960/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@238 PS3, Line 238: isDataInDataFile nit: this was a bit ambiguous for me and had to read the comment of the isDataInDataFile method to understand it. What do you think about using something like: isPartitionColumnValuesInDataFile, isPartitionValuesInDataFile or isPartColValInDataFile http://gerrit.cloudera.org:8080/#/c/17960/3/testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test File testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test: http://gerrit.cloudera.org:8080/#/c/17960/3/testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test@429 PS3, Line 429: select * from functional_parquet.iceberg_partitioned i1, Missing > SET RUNTIME_FILTER_WAIT_TIME_MS=$RUNTIME_FILTER_WAIT_TIME_MS; -- To view, visit http://gerrit.cloudera.org:8080/17960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51b53188c6da7eeebfeae385e1de31ace0980cac Gerrit-Change-Number: 17960 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 25 Oct 2021 16:02:12 +0000 Gerrit-HasComments: Yes
