Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 )
Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/17860/12/be/src/exec/scratch-tuple-batch-test.cc File be/src/exec/scratch-tuple-batch-test.cc: http://gerrit.cloudera.org:8080/#/c/17860/12/be/src/exec/scratch-tuple-batch-test.cc@69 PS12, Line 69: 2, 4, 8, 16, 32 > Verification of micro batches created for randomly assigned true/false woul I see. Let us assume the following: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 F F F F T T F F T T F F F F F F T T F T gap=5 batches formed [4, 9], [16, 19] How do we verify? 1. For any batch i [begin, end, length] a. selected_rows[begin] == selected_rows[end] == T b. The distance of any consecutive T within selected_rows[begin, end] should be no more than gap 2. For any batch i and i+1 a. i.end < (i+1).begin b. (i+1).begin - i.end +1 >= gap Will the above work? -- To view, visit http://gerrit.cloudera.org:8080/17860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46406c913297d5bbbec3ccae62a83bb214ed2c60 Gerrit-Change-Number: 17860 Gerrit-PatchSet: 12 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 26 Oct 2021 16:16:28 +0000 Gerrit-HasComments: Yes
