Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 )
Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. ...................................................................... Patch Set 12: Code-Review+1 (2 comments) Thanks Amogh, this work is truly marvellous. And thanks for measuring code coverage. I think you used test_scanners.py (as we discussed offline). With test_nested_types.py as well I think we would get probably complete code coverage. The change looks great, I'm ready to upgrade my +1 to +2 once it looks OK for the other reviewers. http://gerrit.cloudera.org:8080/#/c/17860/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17860/12//COMMIT_MSG@24 PS12, Line 24: TPCH scale 42 I think it would be good to execute the whole benchmark with bin/single_node_perf_run.py on your dev machine, just to make sure this patch won't cause any regressions. And of course it'd be also interesting to see if there are any significant perf gains in the benchmark queries. http://gerrit.cloudera.org:8080/#/c/17860/10/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17860/10/be/src/exec/parquet/hdfs-parquet-scanner.cc@2223 PS10, Line 2223: c. > We don't need to re-filter after step 3. I will explain it in comment. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/17860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46406c913297d5bbbec3ccae62a83bb214ed2c60 Gerrit-Change-Number: 17860 Gerrit-PatchSet: 12 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 26 Oct 2021 16:56:27 +0000 Gerrit-HasComments: Yes
