Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17878 )
Change subject: IMPALA-10934: Enable table definition over a single file ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/17878/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17878/2//COMMIT_MSG@12 PS2, Line 12: file://somedir/f1.txt nit: could you use the more commonly used 'hdfs' path ? http://gerrit.cloudera.org:8080/#/c/17878/2//COMMIT_MSG@17 PS2, Line 17: This patch enables to use sfs+ wrappers to show a single file as a single file in a directory. nit: the wording here is a bit confusing. How about something like: 'This patch enables a new file system wrapper 'sfs+' (sfs = single file system) which provides a view of a single file in a directory.' The '+' indicates that this wrapper can be added on top of multiple underlying file systems/object storage such as HDFS, S3 etc. Also, the JIRA IMPALA-10934 talks about the corresponding HIVE jira on which this patch depends. Could you mention that in the commit message ? http://gerrit.cloudera.org:8080/#/c/17878/2//COMMIT_MSG@22 PS2, Line 22: Could you add a comment about the Ranger authorization check that this patch also does. http://gerrit.cloudera.org:8080/#/c/17878/2//COMMIT_MSG@23 PS2, Line 23: (cherry picked from commit 998d5a8d72203c9ffead700b2e420049108417c3) Not sure which commit it is referring to, but this should be removed. -- To view, visit http://gerrit.cloudera.org:8080/17878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32be936243aa4c8320f5d06d2b7fbf98822f82e7 Gerrit-Change-Number: 17878 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 27 Oct 2021 20:19:35 +0000 Gerrit-HasComments: Yes
