Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17878 )
Change subject: IMPALA-10934: Enable table definition over a single file ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17878/2/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17878/2/be/src/runtime/io/disk-io-mgr.cc@142 PS2, Line 142: // The maximum number of SFS I/O threads. : DEFINE_int32(num_sfs_io_threads, 16, "Number of SFS I/O threads"); > SFS maps down to some other storage type, and it should be using the logic As a second thought on this, if we are ok with turning off file handle caching, then this approach could work. We are losing some understanding of the underlying storage and some performance, but this is only one file. We should verify the data cache works, and that would generally handle most use cases. -- To view, visit http://gerrit.cloudera.org:8080/17878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32be936243aa4c8320f5d06d2b7fbf98822f82e7 Gerrit-Change-Number: 17878 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Fri, 29 Oct 2021 06:05:35 +0000 Gerrit-HasComments: Yes
