Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17986 )
Change subject: IMPALA-10997: Refactor Java Hive UDF code. ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/17986/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java: http://gerrit.cloudera.org:8080/#/c/17986/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutor.java@483 PS1, Line 483: abstract protected void evaluateDerived(Object... inputArgs) throws ImpalaRuntimeException; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17986/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorLegacy.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorLegacy.java: http://gerrit.cloudera.org:8080/#/c/17986/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorLegacy.java@121 PS1, Line 121: if (javaArgTypes_[i].getPrimitiveType() != parameterTypes[i].getPrimitiveType().toThrift()) { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17986/1/fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java File fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java: http://gerrit.cloudera.org:8080/#/c/17986/1/fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java@82 PS1, Line 82: LOG.debug("Loaded UDF '" + request.fn.scalar_fn.symbol+ "' from " + request.local_location); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17986/1/fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java@150 PS1, Line 150: throw new ImpalaRuntimeException("The class " + className + " does not derive from a " line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b981aed3021aef08c87e7cdbf7c6af95906754 Gerrit-Change-Number: 17986 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 31 Oct 2021 19:49:18 +0000 Gerrit-HasComments: Yes
