Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18020 )
Change subject: IMPALA-10997: Refactor Java Hive UDF code. ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaClass.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaClass.java: http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaClass.java@160 PS1, Line 160: localJarPath = new Path("file://" + localLibPath, UUID.randomUUID().toString() + ".jar"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java@46 PS1, Line 46: /** line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java@60 PS1, Line 60: scalarFn.getSymbolName(), "", PrincipalType.USER, (int) (System.currentTimeMillis() / 1000), line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactory.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactory.java: http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactory.java@47 PS1, Line 47: Type retType, Type[] paramTypes) throws CatalogException { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactory.java@63 PS1, Line 63: public static HiveJavaFunction create(String localLibPath, org.apache.impala.catalog.Function fn) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactory.java@63 PS1, Line 63: public static HiveJavaFunction create(String localLibPath, org.apache.impala.catalog.Function fn) line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactory.java@84 PS1, Line 84: scalarFn.getSymbolName(), "", PrincipalType.USER, (int) (System.currentTimeMillis() / 1000), line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@114 PS1, Line 114: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@163 PS1, Line 163: // Load each method in the UDF class and create the corresponding Impala Function // object. line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18020/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2057 PS1, Line 2057: HiveJavaFunction hiveJavaFunction = (fn.getBinaryType() == TFunctionBinaryType.JAVA) line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/18020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc9572e15fbed1876412159b99dddd3fb4d37174 Gerrit-Change-Number: 18020 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Nov 2021 19:51:42 +0000 Gerrit-HasComments: Yes
