Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18040 )
Change subject: IMPALA-11021: Fix bug when query contains illegal predicate hints ...................................................................... Patch Set 1: (2 comments) Thanks for fixing this issue! http://gerrit.cloudera.org:8080/#/c/18040/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18040/1//COMMIT_MSG@10 PS1, Line 10: key word nit: keyword http://gerrit.cloudera.org:8080/#/c/18040/1//COMMIT_MSG@21 PS1, Line 21: This check is added in IMPALA-4166, I removed this check and add new : test cases for predicate hints. This maybe lead to warnings added : but not displayed, I think this is ok, since warnings added later : is generated by substitute predicate, the original predicate is already : added displayed warnings when creating and initializing TExecRequest. I think it would be nice to preserve something from the original intent, i.e. at least make sure that there are no undisplayed warnings in the first phase. -- To view, visit http://gerrit.cloudera.org:8080/18040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id719bc4280c811456333eb4b4ec5bc9cb8bae128 Gerrit-Change-Number: 18040 Gerrit-PatchSet: 1 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 22 Nov 2021 16:32:26 +0000 Gerrit-HasComments: Yes
