wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18040 )
Change subject: IMPALA-11021: Fix bug when query contains illegal predicate hints ...................................................................... Patch Set 2: Hi Quanlong, thanks for quick reply and explain. Here is some of my opinion. 1. The exception is threw when substituted expr execute analyze(), and called addWarning(). Before creating and initializing TExecRequest, any addWarning() called from exprs' analyze() will succeed. 2. Substituted expr is created by original expr's ctor through clone(), we cannot distinguish if this expr is new or substituted, unless we add a flag in Expr to indicate this, but I think this is too complex. 3. So we don't know if we should calling or avoiding addWarning() in this expr's analyze(), and this is why I just add a new check in addWarning(). This check ensure all substituted exprs' warnings already exists in 'warnings'. 4. Besides, addWarning() is not only called by Expr's analyze, and also other structs, such as StatementBase/TableDef and so on. How do you think? -- To view, visit http://gerrit.cloudera.org:8080/18040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id719bc4280c811456333eb4b4ec5bc9cb8bae128 Gerrit-Change-Number: 18040 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 24 Nov 2021 03:33:34 +0000 Gerrit-HasComments: No
