wangsheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18061 )

Change subject: IMPALA-11040: Remove unnecessary reset() method in class 
'UnionStmt'
......................................................................


Patch Set 1:

Hi, I found most of the members been clear in UnionStmt.reset() is 'SetOperand' 
type, and this class not been extends by other class. So I think it unnecessay 
to reset these members in both UnionStmt.reset() and SetOperationStmt.reset().


--
To view, visit http://gerrit.cloudera.org:8080/18061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I408a396d40d9622f2ae6c459f49cbfcc19affd14
Gerrit-Change-Number: 18061
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Wed, 01 Dec 2021 12:06:32 +0000
Gerrit-HasComments: No

Reply via email to