Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18061 )
Change subject: IMPALA-11040: Remove unnecessary reset() method in class 'UnionStmt' ...................................................................... Patch Set 2: (4 comments) Thanks for working on this fix. http://gerrit.cloudera.org:8080/#/c/18061/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18061/2//COMMIT_MSG@17 PS2, Line 17: caused depth nesting. nit: cause deep nesting. http://gerrit.cloudera.org:8080/#/c/18061/2//COMMIT_MSG@22 PS2, Line 22: will execute slowly, maybe be failed. nit: would execute slowly, or even fail. http://gerrit.cloudera.org:8080/#/c/18061/2/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java: http://gerrit.cloudera.org:8080/#/c/18061/2/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java@a67 PS2, Line 67: I think we probably want this to be executed, we just don't want it to be executed redundantly. Can we just add a flag, e.g. 'boolean resetWasInvoked_;' and return from this function early when it's true? And set it to false in 'analyze()'? http://gerrit.cloudera.org:8080/#/c/18061/2/testdata/workloads/functional-query/queries/QueryTest/union.test File testdata/workloads/functional-query/queries/QueryTest/union.test: http://gerrit.cloudera.org:8080/#/c/18061/2/testdata/workloads/functional-query/queries/QueryTest/union.test@1187 PS2, Line 1187: will execute slowly, even failed. nit: would execute slowly, or even fail. -- To view, visit http://gerrit.cloudera.org:8080/18061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I408a396d40d9622f2ae6c459f49cbfcc19affd14 Gerrit-Change-Number: 18061 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 07 Dec 2021 17:03:17 +0000 Gerrit-HasComments: Yes
