Tamas Mate has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/18068 )
Change subject: IMPALA-11042: Escape special characters in LDAP User DN
......................................................................
IMPALA-11042: Escape special characters in LDAP User DN
The LDAP filter specification assigns special meaning to the following
characters: '*', '(', ')', '\', 'NUL'. These 5 characters should be
escaped with the backslas escape character, followed by the two
character ASCII hexadecimal representation of the character. When the
DN is used in a search filter these escape characters additional
escaping is required. In Impala the user DN can be used in group
searches and this commit adds additional escaping when necessary.
Example DN in directory service:
cn=Ldap\, (Test6*),ou=Users2,dc=myorg,dc=com
Example DN used in filter:
cn=Ldap\5C, \28Test6\2A\29,ou=Users2,dc=myorg,dc=com
Testing:
- Added a custom cluster unti test
- Tested the behaviour manually with OpenLDAP and Active Directory
Change-Id: Ic82e8fc0ff8bbe687632db177385f467dd200dbb
---
M be/src/util/ldap-search-bind.cc
M be/src/util/ldap-search-bind.h
M
fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java
M fe/src/test/java/org/apache/impala/testutil/LdapUtil.java
M fe/src/test/resources/users.ldif
5 files changed, 48 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18068/3
--
To view, visit http://gerrit.cloudera.org:8080/18068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic82e8fc0ff8bbe687632db177385f467dd200dbb
Gerrit-Change-Number: 18068
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
