Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/18068 )
Change subject: IMPALA-11042: Escape special characters in LDAP User DN ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Left a few minor notes about comments and the commit message. Code LGTM. http://gerrit.cloudera.org:8080/#/c/18068/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18068/3//COMMIT_MSG@11 PS3, Line 11: backslas nit: typo http://gerrit.cloudera.org:8080/#/c/18068/3//COMMIT_MSG@13 PS3, Line 13: additional : escaping is required nit: suggest rephrasing as "require additional escaping" to match active/passive voice with the first half of the sentence. http://gerrit.cloudera.org:8080/#/c/18068/3/be/src/util/ldap-search-bind.h File be/src/util/ldap-search-bind.h: http://gerrit.cloudera.org:8080/#/c/18068/3/be/src/util/ldap-search-bind.h@65 PS3, Line 65: the admin should take care of escaping other parts of the filter do you mean here that "other parts of the filter should be provided in an already escaped form"? Is the filter you mention here the user or the group search filter? -- To view, visit http://gerrit.cloudera.org:8080/18068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic82e8fc0ff8bbe687632db177385f467dd200dbb Gerrit-Change-Number: 18068 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 06 Dec 2021 21:24:39 +0000 Gerrit-HasComments: Yes
