Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 )
Change subject: IMPALA-6636: Use async IO in ORC scanner ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc@202 PS20, Line 202: string msg = Substitute( : "Overlapping ORC column ranges. Last end: $0 Current offset:", last_end, : range.offset_); Missing $1 in the string template. http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc@246 PS20, Line 246: string msg = Substitute( : "ORC read request out of range. offset: $0 length: $1", offset, length); : return Status(msg); Need to add filename here and some other site to help debugging if such error indeed happens. http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc@951 PS20, Line 951: VLOG_QUERY << "Encounter parse error: " << e.what(); : parse_status_ = Status(Substitute("Encounter parse error: $0.", e.what())); Add filename information in this error logging. -- To view, visit http://gerrit.cloudera.org:8080/15370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348ad9e55f0cae7dff0d74d941b026dcbf5e4074 Gerrit-Change-Number: 15370 Gerrit-PatchSet: 20 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 07 Jan 2022 20:18:34 +0000 Gerrit-HasComments: Yes
