Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 )
Change subject: IMPALA-6636: Use async IO in ORC scanner ...................................................................... Patch Set 22: (2 comments) http://gerrit.cloudera.org:8080/#/c/15370/21/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15370/21/be/src/exec/hdfs-orc-scanner.cc@165 PS21, Line 165: case orc::StreamKind_DICTIONARY_COUNT: > After confirming with Csaba, the real reason is that we expect that indexes Done http://gerrit.cloudera.org:8080/#/c/15370/21/be/src/exec/hdfs-orc-scanner.cc@252 PS21, Line 252: } : : Status HdfsOrcScanner::ColumnRange::read(void* buf, uint64_t length, uint64_t offset) { : if (offset + length > offset_ + length_) { : string msg = Substitute("ORC read request out of range. offset: $0 length: $1 $2", : offset, length, debug()); : > As we recently figure out, there is a valid case where ORC lib decide to se Added one more case in HdfsOrcScanner::ScanRangeInputStream::read. -- To view, visit http://gerrit.cloudera.org:8080/15370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348ad9e55f0cae7dff0d74d941b026dcbf5e4074 Gerrit-Change-Number: 15370 Gerrit-PatchSet: 22 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 20 Jan 2022 03:19:06 +0000 Gerrit-HasComments: Yes
