Fang-Yu Rao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18256


Change subject: IMPALA-11133: Surround the author field with repr() before 
printing it
......................................................................

IMPALA-11133: Surround the author field with repr() before printing it

We found that compare_branches.py could fail if the author of a commit
contains non-unicode characters because the script attempts to print the
field. This patch fixes the problem by surrounding the author field with
repr() before we print the value.

Testing:
 - Manually verified that we won't get the UnicodeDecodeError after this
   patch.

Change-Id: Ieb03b0937a994db2bf08e4199574d04f7fb99f5d
---
M bin/compare_branches.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18256/1
--
To view, visit http://gerrit.cloudera.org:8080/18256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb03b0937a994db2bf08e4199574d04f7fb99f5d
Gerrit-Change-Number: 18256
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>

Reply via email to