Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18256 )
Change subject: IMPALA-11133: Surround the author field with repr() before printing it ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18256/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18256/1//COMMIT_MSG@10 PS1, Line 10: non-unicode "non-ascii". The error is "'ascii' codec can't decode..." http://gerrit.cloudera.org:8080/#/c/18256/1/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/18256/1/bin/compare_branches.py@270 PS1, Line 270: repr(author) The error is that python2 will implicitly decode the str into unicode using the default encoding (i.e. ascii). I think a more clear way is explicitly calling decode() with the correct encoding, i.e. replacing this with author.decode('utf8') Ref: https://nedbatchelder.com/text/unipain/unipain.html -- To view, visit http://gerrit.cloudera.org:8080/18256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb03b0937a994db2bf08e4199574d04f7fb99f5d Gerrit-Change-Number: 18256 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 22 Feb 2022 00:52:28 +0000 Gerrit-HasComments: Yes
