Fang-Yu Rao has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18256 )
Change subject: IMPALA-11133: Decode author of a commit with utf8 before printing it ...................................................................... IMPALA-11133: Decode author of a commit with utf8 before printing it We found that compare_branches.py could fail if the author of a commit contains non-ASCII characters because the script attempts to print the field. This patch fixes the problem by explicitly decoding the value of author with the encoding 'utf8'. The commit message is also decoded with 'utf8' to prevent similar problems from happening when there are non-ASCII characters in the commit message. Testing: - Manually verified that we won't get the UnicodeDecodeError after this patch. Change-Id: Ieb03b0937a994db2bf08e4199574d04f7fb99f5d --- M bin/compare_branches.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/18256/4 -- To view, visit http://gerrit.cloudera.org:8080/18256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb03b0937a994db2bf08e4199574d04f7fb99f5d Gerrit-Change-Number: 18256 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
