Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18263 )
Change subject: IMPALA-11112: Impala can't resolve json tables created by Hive ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/18263/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18263/2//COMMIT_MSG@9 PS2, Line 9: nit: no indention here http://gerrit.cloudera.org:8080/#/c/18263/2//COMMIT_MSG@11 PS2, Line 11: . nit: add a space after periods. http://gerrit.cloudera.org:8080/#/c/18263/2//COMMIT_MSG@16 PS2, Line 16: } nit: remove this http://gerrit.cloudera.org:8080/#/c/18263/2/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java File fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java: http://gerrit.cloudera.org:8080/#/c/18263/2/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@77 PS2, Line 77: , I think this causes the build failure. http://gerrit.cloudera.org:8080/#/c/18263/2/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/18263/2/tests/metadata/test_hms_integration.py@684 PS2, Line 684: (x int) We should add 'stored as jsonfile' at the end. Otherwise, it's not a json table. http://gerrit.cloudera.org:8080/#/c/18263/2/tests/metadata/test_hms_integration.py@685 PS2, Line 685: % Does it work? Shouldn't it be '+'? 'DESC ' is not a format string. -- To view, visit http://gerrit.cloudera.org:8080/18263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cac55b58dca88d900db3256ceaa25c17d7864d5 Gerrit-Change-Number: 18263 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 23 Feb 2022 01:38:22 +0000 Gerrit-HasComments: Yes
