Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18263 )

Change subject: IMPALA-11112: Impala can't resolve json tables created by Hive
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18263/5/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:

http://gerrit.cloudera.org:8080/#/c/18263/5/tests/metadata/test_hms_integration.py@675
PS5, Line 675:   @pytest.mark.execute_serially
I think we don't need this marker. This test doesn't seem to conflict with 
others.


http://gerrit.cloudera.org:8080/#/c/18263/5/tests/metadata/test_hms_integration.py@676
PS5, Line 676: test_desc_table
nit: test_desc_json_table


http://gerrit.cloudera.org:8080/#/c/18263/5/tests/metadata/test_hms_integration.py@690
PS5, Line 690:
nit: remove the two spaces



--
To view, visit http://gerrit.cloudera.org:8080/18263
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cac55b58dca88d900db3256ceaa25c17d7864d5
Gerrit-Change-Number: 18263
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 23 Feb 2022 07:46:00 +0000
Gerrit-HasComments: Yes

Reply via email to