Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18234 )
Change subject: IMPALA-11008: fix incorrect to propagate inferred predicates ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/18234/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18234/5//COMMIT_MSG@30 PS5, Line 30: To generate the inferred predicate we substitue the non-outer-join > Could you summarize how the bug is fixed? Done http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@514 PS5, Line 514: > nit: remove ":" Done http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@514 PS5, Line 514: he slot id of t > nit: the slot id of t2.id Done http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@515 PS5, Line 515: ojNullableEq > nit: can we indicate 'nullable side' in the var name, e.g. ojNullableEqualS Done -- To view, visit http://gerrit.cloudera.org:8080/18234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e64230f6d0c2b9ef1560186ceba349a5920ccdf Gerrit-Change-Number: 18234 Gerrit-PatchSet: 6 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Wed, 23 Feb 2022 06:17:40 +0000 Gerrit-HasComments: Yes
