Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18234 )
Change subject: IMPALA-11008: fix incorrect to propagate inferred predicates ...................................................................... Patch Set 9: (10 comments) http://gerrit.cloudera.org:8080/#/c/18234/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18234/7//COMMIT_MSG@11 PS7, Line 11: for the n > nit. may remove. Done http://gerrit.cloudera.org:8080/#/c/18234/7//COMMIT_MSG@27 PS7, Line 27: This is > nit. This is incorrect since Done http://gerrit.cloudera.org:8080/#/c/18234/7//COMMIT_MSG@29 PS7, Line 29: l-filteri > nit. remove Done http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@513 PS7, Line 513: cli > nit. delete Done http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@514 PS7, Line 514: > nit. be added to Done http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@515 PS7, Line 515: > nit. maybe ojNullableSlotsInEquiPreds? Done http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2124 PS7, Line 2124: seByConjunct.get(srcConjunct.get > nit. remove Done http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2130 PS7, Line 2130: if (isAntiJoinedConjunct(srcConjunct)) continue; > nit. save the mapping from src to the outer join equal slot. Done http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2150 PS7, Line 2150: final substitution. : ExprSubstitutionMap smap = new ExprSubstitutionMap(); : Exp > I wonder if this is a redundant operation since the content of ojmap is a s The 'ojmap' is not a subset of 'smap'. The slots in 'ojNullableEqualSlots' will be added to 'ojmap', others be added to 'smap'. http://gerrit.cloudera.org:8080/#/c/18234/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2729 PS7, Line 2729: // the joined table -> ignore this, we can't reason about when it'll : // actually be true > Should we handle FULL_OUTER_JOIN and ANTI joins? 1.We don't add value-transfer edges based on full outer joins, see #2697. 2.The anti join returns rows in the one table that have no matching rows in the other table. For example, the left anti join returns rows in the left table, we don't need to handle anti join since there are no conditions about the right table after left anti join. -- To view, visit http://gerrit.cloudera.org:8080/18234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e64230f6d0c2b9ef1560186ceba349a5920ccdf Gerrit-Change-Number: 18234 Gerrit-PatchSet: 9 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Tue, 29 Mar 2022 07:07:50 +0000 Gerrit-HasComments: Yes
