Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18226 )
Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/18226/9/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/18226/9/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1948 PS9, Line 1948: private static class IcebergMetaCacheKey extends VersionedTableCacheKey { This calculates the same hash value as PartitionListCacheKey (and VersionedTableCacheKey). We don't invoke loadPartitionList() for Iceberg tables so it doesn't cause a problem, but maybe it'd be safer to override hashCode(). Because some other load method might also start to use VersionedTableCacheKey and its hashCode() method. So how about e.g.: @Override public int hashCode() { return Objects.hashCode(super.hashCode(), getClass()); } -- To view, visit http://gerrit.cloudera.org:8080/18226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e62a1fb9753ea1b022c7763047d9ccfd1d27d62 Gerrit-Change-Number: 18226 Gerrit-PatchSet: 9 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 04 Mar 2022 11:53:51 +0000 Gerrit-HasComments: Yes
