Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18353 )
Change subject: IMPALA-10737: Optimize the number of Iceberg API Metadata requests ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@336 PS2, Line 336: FeIcebergTable.super Is supert.snapshotId() not enough? http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1062 PS2, Line 1062: iceberg api metadata iceberg api table? http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@145 PS2, Line 145: // TODO: get rid of try-catch TableLoadingException once we have IMPALA-10737. Please remove the try-catch http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/18353/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@853 PS2, Line 853: //TODO: avoid loading the table once we have IMPALA-10737 again: : Table iceTbl = loadTable(feTbl); Please use getIcebergApiTable() -- To view, visit http://gerrit.cloudera.org:8080/18353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5492e0cdb31602f0276029c2645d14ff5cb2f672 Gerrit-Change-Number: 18353 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:17:04 +0000 Gerrit-HasComments: Yes
