Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 )
Change subject: IMPALA-11153: Expose LOCK_RETRIES/LOCK_RETRY_WAIT_SECONDS settings for user ...................................................................... Patch Set 3: (1 comment) PS3 is only a rebase. http://gerrit.cloudera.org:8080/#/c/18289/2/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/18289/2/common/thrift/CatalogService.thrift@171 PS2, Line 171: lock_retry_wait_seconds > Aren't we pessimistic about "seconds"? I don't know how much overhead do we >From the name of the config at first I thought Hive uses 1 minute sleep >interval... Then I realized it is only a maximum value, and Hive does exponential backoff: https://github.com/apache/hive/blob/7b3ecf617a6d46f48a3b6f77e0339fd4ad95a420/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java#L95-L97 I think it would be reasonable for us as well, so I switched to a backoff logic. -- To view, visit http://gerrit.cloudera.org:8080/18289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055b76138dd30b2c40eedb48905cb3bade1438fc Gerrit-Change-Number: 18289 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 28 Mar 2022 14:39:43 +0000 Gerrit-HasComments: Yes
