Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18289 )
Change subject: IMPALA-11153: Make lock wait time configurable for the users ...................................................................... Patch Set 4: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java File fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@620 PS2, Line 620: * lock doesn't belong to a transaction. > nit: alignment is off here, but as I see we don't have a consistent style f Done http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@483 PS2, Line 483: ddlRequest.getLock_max_wait_time_s()); > Just an idea to make passing these parameters simpler: the params in ddlReq I haven't done it in the current PS as I decreased the number of new query options. But I can do it in a new PS if you still think it'd make sense. http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/18289/2/fe/src/main/java/org/apache/impala/service/Frontend.java@2195 PS2, Line 2195: > missing comment of queryOptions param Done http://gerrit.cloudera.org:8080/#/c/18289/2/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/18289/2/tests/query_test/test_acid.py@334 PS2, Line 334: assert elapsed < 5 > this should be < 3 I think, as >3 && < 5 would mean we had 1 retry I changed the code since then. Now there's only one query option. -- To view, visit http://gerrit.cloudera.org:8080/18289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055b76138dd30b2c40eedb48905cb3bade1438fc Gerrit-Change-Number: 18289 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 28 Mar 2022 17:58:34 +0000 Gerrit-HasComments: Yes
