Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18423 )
Change subject: IMPALA-11237: Preserve the behavior of concat_ws() before IMPALA-8891 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18423/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18423/1//COMMIT_MSG@10 PS1, Line 10: query option of 'CONCAT_WS_RETURN_NULL_IF_ANY_IS_NULL' My understanding is that generally skipping nulls is the expected behavior instead of returning NULL - checked Hive, postgresql, MsSql, MySql, and all behave this way. So I don't expect our "old behavior" to be common request by users. To make the change simpler, we could simply use a flag instead. -- To view, visit http://gerrit.cloudera.org:8080/18423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fe11971e0c56b868bdf8bf1b071d40d9837acda Gerrit-Change-Number: 18423 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Apr 2022 16:08:15 +0000 Gerrit-HasComments: Yes
