Fang-Yu Rao has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18440 )
Change subject: IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891 ...................................................................... IMPALA-11237: Preserve the behavior of CONCAT_WS() before IMPALA-8891 This patch preserves the behavior of CONCAT_WS() before IMPALA-8891 by introducing a flag of 'concat_ws_return_null_if_any_is_null', which is set to false by default. Specifically, if 'concat_ws_return_null_if_any_is_null' is set to true when the Impala daemon is started, CONCAT_WS() will return NULL as long as any of the argument values is NULL, which corresponds to the behavior before IMPALA-8891. Testing: - Added an E2E test to verifiy the behavior before IMPALA-8891 could be preserved once the flag above is set to true when the Impala daemon is started. Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6 --- M be/src/exprs/string-functions-ir.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h A testdata/workloads/functional-query/queries/QueryTest/test_concat_ws.test A tests/custom_cluster/test_concat_ws.py 5 files changed, 117 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18440/3 -- To view, visit http://gerrit.cloudera.org:8080/18440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I295adf4d4eeec7af43bb05644462e44024b6a2f6 Gerrit-Change-Number: 18440 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com>
