Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 )
Change subject: IMPALA-9410: Support resolving ORC file columns by names ...................................................................... Patch Set 5: Code-Review+1 (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/18397/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18397/5//COMMIT_MSG@14 PS5, Line 14: Could you addd "Testing:" before the paragraph that is about testing? This is just a small commit style nit. http://gerrit.cloudera.org:8080/#/c/18397/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-tables.test: http://gerrit.cloudera.org:8080/#/c/18397/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-tables.test@77 PS5, Line 77: Currently this fails due to IMPALA-9410 nit: This won't fail anymore. -- To view, visit http://gerrit.cloudera.org:8080/18397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29562a059160c19eb58ccea76aa959d2e408f8de Gerrit-Change-Number: 18397 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 May 2022 08:59:51 +0000 Gerrit-HasComments: Yes
