Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 )
Change subject: IMPALA-9410: Support resolving ORC file columns by names ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/18397/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18397/5//COMMIT_MSG@12 PS5, Line 12: startegy typo: strategy http://gerrit.cloudera.org:8080/#/c/18397/5/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/18397/5/be/src/exec/orc-metadata-utils.cc@47 PS5, Line 47: schema_resolution_strategy_ = schema_resolution nit: it could be added to the init-list. http://gerrit.cloudera.org:8080/#/c/18397/5/be/src/exec/orc-metadata-utils.cc@184 PS5, Line 184: table_idx at this level table_idx can be -1. E.g. the following crashes Impala: set orc_schema_resolution=name; select id from alltypestiny; http://gerrit.cloudera.org:8080/#/c/18397/5/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/18397/5/tests/query_test/test_nested_types.py@64 PS5, Line 64: cls.ImpalaTestMatrix.add_dimension(ImpalaTestDimension('orc_schema_resolution', 0, 1)) We could also add this dimension to some tests in test_scanners.py as well. http://gerrit.cloudera.org:8080/#/c/18397/5/tests/query_test/test_nested_types.py@65 PS5, Line 65: () missing argument, the above method expects 'vector' -- To view, visit http://gerrit.cloudera.org:8080/18397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29562a059160c19eb58ccea76aa959d2e408f8de Gerrit-Change-Number: 18397 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 May 2022 13:35:20 +0000 Gerrit-HasComments: Yes
