Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18528
Change subject: IMPALA-11208: Fix uninitialized counter of CollectionItemsRead in orc-scanner ...................................................................... IMPALA-11208: Fix uninitialized counter of CollectionItemsRead in orc-scanner CollectionItemsRead in the runtime profile counts the total number of nested collection items read by the scan node. Only created for scans that support nested types, e.g. Parquet or ORC. Each scanner thread maintains its local counter and merges it into HdfsScanNode counter for each row batch. However, the local counter in orc-scanner is uninitialized, leading to weird values. This patch simply initializes it to 0 and add test coverage. Tests: - Add profile verifiers in tpch tests. There are no nested tables so the CollectionItemsRead should all be 0. Change-Id: Id7783d1460ac9b98e94d3a31028b43f5a9884f99 --- M be/src/exec/hdfs-orc-scanner.h M testdata/workloads/tpch/queries/tpch-q1.test M testdata/workloads/tpch/queries/tpch-q10.test M testdata/workloads/tpch/queries/tpch-q11.test M testdata/workloads/tpch/queries/tpch-q12.test M testdata/workloads/tpch/queries/tpch-q13.test M testdata/workloads/tpch/queries/tpch-q14.test M testdata/workloads/tpch/queries/tpch-q15.test M testdata/workloads/tpch/queries/tpch-q16.test M testdata/workloads/tpch/queries/tpch-q17.test M testdata/workloads/tpch/queries/tpch-q18.test M testdata/workloads/tpch/queries/tpch-q19.test M testdata/workloads/tpch/queries/tpch-q2.test M testdata/workloads/tpch/queries/tpch-q20.test M testdata/workloads/tpch/queries/tpch-q21.test M testdata/workloads/tpch/queries/tpch-q22.test M testdata/workloads/tpch/queries/tpch-q3.test M testdata/workloads/tpch/queries/tpch-q4.test M testdata/workloads/tpch/queries/tpch-q5.test M testdata/workloads/tpch/queries/tpch-q6.test M testdata/workloads/tpch/queries/tpch-q7.test M testdata/workloads/tpch/queries/tpch-q8.test M testdata/workloads/tpch/queries/tpch-q9.test 23 files changed, 63 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/18528/1 -- To view, visit http://gerrit.cloudera.org:8080/18528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id7783d1460ac9b98e94d3a31028b43f5a9884f99 Gerrit-Change-Number: 18528 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]>
