Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18528 )
Change subject: IMPALA-11208: Fix uninitialized counter of CollectionItemsRead in orc-scanner ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18528/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18528/1//COMMIT_MSG@16 PS1, Line 16: add > Nit: adds. Done http://gerrit.cloudera.org:8080/#/c/18528/1//COMMIT_MSG@19 PS1, Line 19: There are no nested tables so : the CollectionItemsRead should all be 0. > This is not clear to me - we don't have any table or tests that would chang Sorry, I mean the modified tests in this patch set don't query nested tables so the counter should be 0. I should have added tests for non zero cases. Done in the next patch set. -- To view, visit http://gerrit.cloudera.org:8080/18528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7783d1460ac9b98e94d3a31028b43f5a9884f99 Gerrit-Change-Number: 18528 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 18 May 2022 03:47:58 +0000 Gerrit-HasComments: Yes
