Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 )
Change subject: IMPALA-10851: Codegen for structs ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/codegen/codegen-anyval.cc@773 PS1, Line 773: void CodegenAnyVal::StoreStructToNativePtr(llvm::Value* main_tuple_ptr, llvm::Value* struct_slot_ptr, line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/exprs/slot-ref.cc File be/src/exprs/slot-ref.cc: http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/exprs/slot-ref.cc@315 PS1, Line 315: llvm::BasicBlock* child_block = llvm::BasicBlock::Create(codegen->context(), "child", fn); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/exprs/slot-ref.cc@406 PS1, Line 406: // than having read_slot_block generate an AnyVal and having a single phi node over that. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/exprs/slot-ref.cc@425 PS1, Line 425: llvm::PHINode* ptr_phi = CodegenPHINode(builder, ptr, ptr_null, non_null_incoming_block, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/exprs/slot-ref.cc@429 PS1, Line 429: llvm::PHINode* len_phi = CodegenPHINode(builder, len, len_null, non_null_incoming_block, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18526/1/be/src/exprs/slot-ref.cc@508 PS1, Line 508: CodegenAnyVal SlotRef::CodegenValue(LlvmCodeGen* codegen, LlvmBuilder* builder, llvm::Function* fn, line too long (99 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5272c3f095fd9f07877104ee03c8e43d0c4ec0b6 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 16 May 2022 13:15:22 +0000 Gerrit-HasComments: Yes
