Daniel Becker has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/18526 )
Change subject: IMPALA-10851: Codegen for structs
......................................................................
IMPALA-10851: Codegen for structs
IMPALA-9495 added support for struct types in SELECT lists but only with
codegen turned off. This commit implements codegen for struct types.
To facilitate this, the code in SlotRef::GetCodegendComputeFnImpl() and
CodegenAnyVal::WriteToSlot() has been refactored to allow recursion,
which is needed to
- read structs from tuples and procude 'StructVal's and
- to write 'StructVal's to tuples.
Testing:
- enabling tests for structs in select list in codegen mode in
tests/query_test/test_nested_types.py
Change-Id: I5272c3f095fd9f07877104ee03c8e43d0c4ec0b6
---
M be/src/codegen/codegen-anyval.cc
M be/src/codegen/codegen-anyval.h
M be/src/codegen/gen_ir_descriptions.py
M be/src/codegen/impala-ir.cc
M be/src/exprs/CMakeLists.txt
M be/src/exprs/hive-udf-call-ir.cc
M be/src/exprs/hive-udf-call.h
A be/src/exprs/scalar-expr-evaluator-ir.cc
M be/src/exprs/scalar-expr-evaluator.h
M be/src/exprs/slot-ref.cc
M be/src/exprs/slot-ref.h
M be/src/runtime/descriptors.cc
M be/src/runtime/descriptors.h
M be/src/runtime/tuple.cc
M be/src/udf/udf-internal.h
M be/src/udf/udf-ir.cc
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/authorization/test_ranger.py
M tests/query_test/test_nested_types.py
20 files changed, 907 insertions(+), 318 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/18526/3
--
To view, visit http://gerrit.cloudera.org:8080/18526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5272c3f095fd9f07877104ee03c8e43d0c4ec0b6
Gerrit-Change-Number: 18526
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>