Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18529 )
Change subject: IMPALA-11291: deflake minidump-test by not starting JVM ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thanks for fixing it! I wasn't sure what you'd prefer for flaky tests, quick fix or revert. I could make this more resilient by filtering for just the relevant messages, should I follow up with another patch to do that so we can still batch them? http://gerrit.cloudera.org:8080/#/c/18529/1/be/src/util/minidump-test.cc File be/src/util/minidump-test.cc: http://gerrit.cloudera.org:8080/#/c/18529/1/be/src/util/minidump-test.cc@49 PS1, Line 49: EXPECT_EQ(3, lines.size()) << output; Oh, totally missed this nuance for providing a custom error message! -- To view, visit http://gerrit.cloudera.org:8080/18529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89f81d408a2e905d5dfdd7f87177ebe2079d4d27 Gerrit-Change-Number: 18529 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 16 May 2022 16:52:55 +0000 Gerrit-HasComments: Yes
