Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18529 )
Change subject: IMPALA-11291: deflake minidump-test by not starting JVM ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+1 > > (1 comment) > > Thanks for fixing it! I wasn't sure what you'd prefer for flaky tests, quick > fix or revert. > > I could make this more resilient by filtering for just the relevant messages, > should I follow up with another patch to do that so we can still batch them? Thanks! I think it's ok to leave this patch as-is. The log of the JVM pause monitor can interleave in the middle of the minidump output, so it might not be easy to add robust filters. > Patch Set 2: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8111/ The GVO failure is unrelated to this patch. I just submitted a re-run. -- To view, visit http://gerrit.cloudera.org:8080/18529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89f81d408a2e905d5dfdd7f87177ebe2079d4d27 Gerrit-Change-Number: 18529 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 17 May 2022 02:21:39 +0000 Gerrit-HasComments: No
