Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18535 )
Change subject: IMPALA-11289: Push-down compound predicates to iceberg ...................................................................... Patch Set 1: (2 comments) Looks pretty clear, but trying to understand tests and looks like a comment is outdated. http://gerrit.cloudera.org:8080/#/c/18535/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18535/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@81 PS1, Line 81: // Exprs in icebergConjuncts_ converted to UnboundPredicate. This comment no longer seems accurate. http://gerrit.cloudera.org:8080/#/c/18535/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test: http://gerrit.cloudera.org:8080/#/c/18535/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test@79 PS1, Line 79: aggregation(SUM, NumRowGroups): 2 What about this test shows that it's pushing predicates down to iceberg? -- To view, visit http://gerrit.cloudera.org:8080/18535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bc67b71033900c466183da5b1907ac90844177 Gerrit-Change-Number: 18535 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 17 May 2022 19:13:14 +0000 Gerrit-HasComments: Yes
