Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18535 )
Change subject: IMPALA-11289: Push-down compound predicates to iceberg ...................................................................... Patch Set 3: (2 comments) This seems fine, I'm just trying to understand how the test cases verify this change. http://gerrit.cloudera.org:8080/#/c/18535/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18535/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@81 PS1, Line 81: // Exprs in icebergConjuncts_ converted to Expression. > Done Ack http://gerrit.cloudera.org:8080/#/c/18535/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test: http://gerrit.cloudera.org:8080/#/c/18535/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test@79 PS1, Line 79: aggregation(SUM, NumRowGroups): 2 > Thanks for your CR! This likely comes from my own lack of knowledge, but it's not clear to me how this test case would change if we weren't pushing predicates down to iceberg. Would the query have failed? Would the runtime_profile differ? -- To view, visit http://gerrit.cloudera.org:8080/18535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bc67b71033900c466183da5b1907ac90844177 Gerrit-Change-Number: 18535 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 18 May 2022 17:40:19 +0000 Gerrit-HasComments: Yes
