[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18535 )
Change subject: IMPALA-11289: Push-down compound predicates to iceberg ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18535/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18535/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@233 PS4, Line 233: icebergPredicates_.add(predicate); > nit: maybe add some debug logging about the predicates that are pushed down Good suggestion. Debug log messages will be similar to "Push down the predicate: (ref(name="col_bi_0") == 0 or is_null(ref(name="col_bi_1"))) to iceberg" http://gerrit.cloudera.org:8080/#/c/18535/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test: http://gerrit.cloudera.org:8080/#/c/18535/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test@72 PS4, Line 72: and ( : col_ts in ('1500-01-01 00:00:00') : or col_db = 2.71823 : ); > Could you please add a test with a longer chain of 'or' operators? Eg. Done http://gerrit.cloudera.org:8080/#/c/18535/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18535/4/tests/query_test/test_iceberg.py@626 PS4, Line 626: use_db > There is no need to mark these tests to run serially (this and the other tw Done -- To view, visit http://gerrit.cloudera.org:8080/18535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27bc67b71033900c466183da5b1907ac90844177 Gerrit-Change-Number: 18535 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 24 May 2022 03:09:26 +0000 Gerrit-HasComments: Yes
