Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 )
Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ...................................................................... Patch Set 16: (11 comments) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exec/hdfs-avro-scanner.cc@642 PS16, Line 642: success = ReadAvroVarchar(slot_type, state_->utf8_mode(), slot_desc->type().char_len, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exec/hdfs-avro-scanner.cc@645 PS16, Line 645: success = ReadAvroChar(slot_type, state_->utf8_mode(), slot_desc->type().char_len, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exec/hdfs-orc-scanner.cc@1152 PS16, Line 1152: dst_ptr = reinterpret_cast<char*>(search_args_pool_->TryAllocate(dst_type.char_len)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exec/orc-column-readers.cc@304 PS16, Line 304: StringValue::PadWithSpaces(dst_char, slot_desc_->type().GetMaxByteLen(), unpadded_len); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/exprs/anyval-util.h@311 PS16, Line 311: FindUtf8PosForward(reinterpret_cast<const char*>(slot), type.char_len * 4, type.char_len) line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/runtime/raw-value.cc@84 PS16, Line 84: int str_len = type.is_utf8 ? FindUtf8PosForward(chars, type.char_len * 4, type.char_len) : type.char_len; line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/runtime/raw-value.cc@123 PS16, Line 123: int str_len = type.is_utf8 ? FindUtf8PosForward(chars, type.char_len * 4, type.char_len) : type.char_len; line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/runtime/raw-value.cc@363 PS16, Line 363: int str_len = type.is_utf8 ? FindUtf8PosForward(chars, type.char_len * 4, type.char_len) : type.char_len; line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/service/fe-support.cc@147 PS16, Line 147: if (type.is_utf8) str_len = FindUtf8PosForward(chars, type.char_len * 4, type.char_len); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/service/hs2-util.cc@310 PS16, Line 310: FindUtf8PosForward(chars, char_type.char_len * 4, char_type.char_len) : char_type.char_len; line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/16909/16/be/src/service/hs2-util.cc@637 PS16, Line 637: FindUtf8PosForward(chars, char_type.char_len * 4, char_type.char_len) : char_type.char_len; line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62efa3042c64d1d005a2cf4fd1d31e992543963f Gerrit-Change-Number: 16909 Gerrit-PatchSet: 16 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 25 May 2022 04:07:55 +0000 Gerrit-HasComments: Yes
