Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 )
Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ...................................................................... Patch Set 18: (6 comments) http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exec/hdfs-avro-scanner-ir.cc File be/src/exec/hdfs-avro-scanner-ir.cc: http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exec/hdfs-avro-scanner-ir.cc@231 PS18, Line 231: // 'max_char_len' is an int, so the result of min() should always be in [0, INT_MAX]. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exec/hdfs-avro-scanner-ir.cc@254 PS18, Line 254: // 'max_char_len' is an int, so the result of min() should always be in [0, INT_MAX]. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exprs/anyval-util.h@310 PS18, Line 310: FindUtf8PosForward(reinterpret_cast<const char*>(slot), type.char_len * 4, type.char_len) line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exprs/conditional-functions-ir.cc File be/src/exprs/conditional-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exprs/conditional-functions-ir.cc@30 PS18, Line 30: int type_byte_size = ctx->impl()->GetConstFnAttr(FunctionContextImpl::RETURN_TYPE_BYTE_SIZE); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exprs/math-functions-ir.cc@589 PS18, Line 589: int type_byte_size = ctx->impl()->GetConstFnAttr(FunctionContextImpl::RETURN_TYPE_BYTE_SIZE); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/16909/18/be/src/exprs/math-functions-ir.cc@675 PS18, Line 675: int type_byte_size = ctx->impl()->GetConstFnAttr(FunctionContextImpl::RETURN_TYPE_BYTE_SIZE); line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62efa3042c64d1d005a2cf4fd1d31e992543963f Gerrit-Change-Number: 16909 Gerrit-PatchSet: 18 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 28 May 2022 10:35:00 +0000 Gerrit-HasComments: Yes
