Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 )
Change subject: IMPALA-11314: Test PyPI package with system python ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/18586/5/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/18586/5/bin/bootstrap_system.sh@282 PS5, Line 282: # Install Python 2.x explicitly for CentOS 8 : function setup_python2() > Using OS virtualenv is more realistic for users, and the requirements.txt f I don't think the specific version of virtualenv is likely to cause issues. I opted to use the one we already set up to avoid downloading more packages. http://gerrit.cloudera.org:8080/#/c/18586/8/bin/impala-virtualenv File bin/impala-virtualenv: http://gerrit.cloudera.org:8080/#/c/18586/8/bin/impala-virtualenv@20 PS8, Line 20: source "$(dirname "$0")/impala-python-common.sh" I think I ran into a race-condition with multiple build steps trying to run bootstrap_virtualenv. I need to dig into where we should add an artificial dependency to serialize that. -- To view, visit http://gerrit.cloudera.org:8080/18586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I384ea6a7dab51945828cca629860400a23fa0c05 Gerrit-Change-Number: 18586 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Jun 2022 18:30:08 +0000 Gerrit-HasComments: Yes
