Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 )
Change subject: IMPALA-11314: Test PyPI package with system python ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/18586/9/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18586/9/shell/CMakeLists.txt@29 PS9, Line 29: COMMAND env BUILD_VERSION=install-test OFFICIAL=true "DIST_DIR=${CMAKE_SOURCE_DIR}/shell/build" Putting this in shell/build ends up cleaning shell/build without NO_CLEAN_DIST. Can add NO_CLEAN_DIST, or put it in its own subdirectory. I opted to put it in build since it's part of the build process. -- To view, visit http://gerrit.cloudera.org:8080/18586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I384ea6a7dab51945828cca629860400a23fa0c05 Gerrit-Change-Number: 18586 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Jun 2022 22:11:40 +0000 Gerrit-HasComments: Yes
